Use of "parent" in callables is deprecated

[Randem]

Hi,

We are using SMF 2.1.4 on Apache 2.4, PHP 8.2.20 and get the error message "Use of "parent" in callables is deprecated" in our log file many times.

Here is the line of code that causes the issue:



Here is the back trace:

[shawnb61]

This is very interesting...  I run PHP 8.2 in production, and have js/css minimization enabled, and do not get this error.

Note that this was in fact deprecated in 8.2.  This probably belongs on the bug reports board.  A fix is definitely needed.

Related issue & thread up on GitHub:
https://github.com/SimpleMachines/SMF/issues/8244

In the meanwhile, if the errors are a problem, you may need to go back to PHP 8.1.

[Tyrsson]

Very odd since the line numbers do not match the current release-2.1 and this is the line in question I believe...

Code Select Expand

call_user_func_array(array('\\MatthiasMullie\Minify\\Minify', '__construct'), func_get_args());


[Randem]

This is the version that we have... If there is a different version it is not in 2.1.4...

[Tyrsson]

Well here is that file in the release-2.1 branch so I'm not sure if I'm missing something or what.

https://github.com/SimpleMachines/SMF/blob/5462b63509a5c7bb63ca17e1a59bbcd915901893/Sources/minify/src/JS.php#L130C9-L130C104

[Randem]

Thanks, I will try it. Github must have different versions than the SMF site... I checked all the way back to version 2.1.1 and the file is the same as the one in 2.1.4.

[Tyrsson]

Yea, Im not sure when that got merged. I'm not a real big fan of the git model that SMF uses. But it should have been built against this tag:

https://github.com/SimpleMachines/SMF/releases/tag/v2.1.4

[shawnb61]

The bug is in 2.1.4 (& 3.0).

Yes, a fix went in for 2.1.5 to attempt to address.  That's why the line in error doesn't match current GH.

But as you can see in the issue referenced above, there is still an open issue with this logic even with the current fix slated for 2.1.5.
https://github.com/SimpleMachines/SMF/issues/8244

It needs more work.

[Tyrsson]

Yes, a fix went in for 2.1.5 to attempt to address.  That's why it doesn't match current GH.

But as you can see in the issue referenced above, there is still an open issue with this logic even with the current fix slated for 2.1.5.
https://github.com/SimpleMachines/SMF/issues/8244

Which is why I do not like the git strategy that is used I prefer a "merge up strategy" based on a 2.1.x working branch. I mean is there going to be a 2.1.5 release? Who knows...