News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

Yandex Garland

Started by Vladimir Samoilov, June 29, 2013, 04:42:00 AM

Previous topic - Next topic

@rjen

Since Christmas is getting closer I reactivated the mod again.

Surprise that the sounds are no longer being played. They where last year when I switched the mod off.
This seams to be the same in any browser.

Uninstalling and reinstalling the mod does nog change the behaviour.

Now I have seen that the mod uses Javascript and a shockwave flash (.swf) file to play the sounds and in 2015 at least Chrome stopped supporting some flash animations. Could it be that the mod is outdated for the latest browsers?
Still have the mod activated ( www.fjr-club.nl ), but some users are missing the tingling sounds the bells used to make when hovering a mouse over the christmas balls...
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

Tonyvic

I just installed the mod, and can hear the sound ok with Edge, Firefox and Chrome which are all the latest versions. ???

@rjen

What forum url is it? Maybe it is my pc?
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

@rjen

Just installed a clean smf version on my laptop, and installed the mod again, and you are right, it works now!

So there must be something conflicting in my forum...
I tried replacing various files with the original ones (sources / themes / css / script) but no luck...  >:(

The balls move, but NO SOUND... any idea where to look?


Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

Tonyvic

Sorry @rjen I haven't a clue, hopefully someone with knowledge will be along soon.

Manius

Hello! And anyone know how to install IPS 4.x?

Vladimir Samoilov

Hello, @rjen.

Could you show the full list of installed mods on your forum, please?

Vladimir Samoilov

Quote from: Manius on December 13, 2015, 06:23:22 AM
Hello! And anyone know how to install IPS 4.x?

This mod for SMF only. But you can copy and some code for install it manually.

@rjen

Quote from: mamavrn on December 15, 2015, 03:01:59 AM
Hello, @rjen.

Could you show the full list of installed mods on your forum, please?

Sure, below the mods.

Most of them were already active last year...

1.   Optimus Brave   1.8.7 
2.   Responsive Curve   1.0 Beta 5 
3.   TinyPortal   1.2 
4.   Google Analytics Code   1.4 
5.   Group Attachment Limits   1.1.0 
6.   EU Cookie FJR   1.3fjr 
7.   Users Online Today   2.1 
8.   Order Custom Profile Fields   1.1.1 
9.   Downloads System   2.5 
10.   Previous and Next Links for Page Index   2.1.204 
11.   AJAX Recent Topics   1.1 
12.   Alternate User Posting   1.0.1 
13.   Custom Board Sort   1.0.2 
14.   View Only Boards   1.2c 
15.   Force Topic Read On Login Mod   2.1 
16.   Voter Visibility   2.0 FJR 
17.   Simple Audio Video Embedder   3.5a 
18.   YandexGarland   1.2 
19.   Ignore Topics   2.3 
20.   Auto Lock Old Topics   2.0 
21.   Float BBCODE   1.0.2 
22.   Tapatalk SMF 2.0 Plugin   4.3.3 
23.   Users Online Today   2.0.3
24.   SMF Theme Changer   1.0.1 
25.   Remove "Last edit" mod   0.2.5 
26.   SMFPacks Shoutbox   1.0.5 
27.   Add Social Media Icons To Profiles FJR   1.2.0 
28.   SMF 2.0.11 Update   1.0 
29.   Enhanced PM System   3.1 
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

@rjen

It seems I am geting closer to finding the cause. On my local forum version I have one by one installed the latest additions to my mods and I think I have found the cause: Tinyportal 1.2

Yandex works ok (with sound) then I install TP version 1.2 and the sound stops working. Uninstalling tinyportal: and the sound works again... Last year I was still on version 1.0 of TP: it worked ok then...

I did a check in the code changes TP makes but I cannot see the cause of the conflict. Maybe someone more knowledgable can help here?

TP install affects the follwing files:

1.   Extract Tree   ./Themes
2.   Extract Tree   ./Sources
3.   Extract Tree   ./tp-downloads
4.   Extract Tree   ./tp-images
5.   Extract Tree   ./tp-files
6.   Execute Modification   ./index.php
7.   Execute Modification   ./Sources/Load.php
8.   Execute Modification   ./Sources/Subs.php
9.   Execute Modification   ./SSI.php
10.   Execute Modification   ./Sources/QueryString.php
11.   Execute Modification   ./Sources/Subs-Editor.php
12.   Adapt Database   install.php
13.   Execute Code   do_hooks.php

Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

@rjen

Fixed!

I found the conflict: in TPortal.php.
As a result jquery is loaded twice: once by Yandex, once by TP...



// Load JQuery if it's not set (anticipated for SMF2.1)
if (!isset($modSettings['jquery_source']))
$context['html_headers'] .= '
<script src="http://code.jquery.com/jquery-1.10.1.min.js"></script>';


Since it suggests it is there for SMF 2.1 I commented out the code: and now it works again. I see no direct downside on Tinyportal...
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

Vladimir Samoilov

Quote from: @rjen on December 15, 2015, 03:40:14 PM
Fixed!

I found the conflict: in TPortal.php.
As a result jquery is loaded twice: once by Yandex, once by TP...



// Load JQuery if it's not set (anticipated for SMF2.1)
if (!isset($modSettings['jquery_source']))
$context['html_headers'] .= '
<script src="http://code.jquery.com/jquery-1.10.1.min.js"></script>';


Since it suggests it is there for SMF 2.1 I commented out the code: and now it works again. I see no direct downside on Tinyportal...

Good morning! :)
Thank you for your investigation! It will be helpfull for another TP users.

@rjen

Also a note to Yandexgarland mod developer, for future reference:

come SMF 2.1 you will need to remove the jquery call from the yandexgarland mod as SMF 2.1 calls jquery by default.
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

Black Tiger

I know it's almost 3 years ago, but anyone still using this?
Last year in Firefox the bells and sounds worked.

I did not add any new mods, but now I only see the bells, no sound in Chrome and Firefox, which did some major changes the past year.
With Internet Explorer 11 the sound still works.

These are my mods:
1.    Contact Page    3.2
2.    SMF 2.0.15 Update    1.0
3.    YandexGarland    1.2
4.    SimplePortal    2.3.7
5.    Remove "Last edit" mod    0.2.5
6.    Tapatalk SMF 2.0 Plugin    4.4.1
7.    Redirection Topics    1.0.3
8.    Downloads System    2.5
9.    Image Upload    1.0.0    [ Install Mod ] [ List Files ] [ Delete ]
10.    Optimus    1.9.6
11.    Birthday On Register    1.0
12.    My Posts SMF2    1.2

But they were present end 2016 too, only versions are updated.
Anyone else having the sound issue this year with FF or Chrome?
Greetings, Black Tiger

Black Tiger

Seems YandexGarland is not 100% SSL compatible, it formerly also worked without issues with Dziners's Xmas-20a theme. But not if you scroll to the end of the page it will keep giving white space and keeps loading when Yandex is enabled.

For example I had to change this code:
http://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js
to
https://ajax.googleapis.com/ajax/libs/jquery/1.8.3/jquery.min.js
for the bells to move in Chrome and Firefox. Sound still did not work and we got that sudden conflict with the Dziners theme.

If disabled, problem is gone, now so this mod really needs some updating. :)
Greetings, Black Tiger

@rjen

Thanks for the tip on the SSL. I had the same issue: now the balls move again.

I am still missing the sounds (fix I did two years ago still in place) ... any idea where to look for that one ?
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

Shambles

You'll have to install/enable Adobe Flash to get sound

Black Tiger

Flash is installed and enabled.

@Arjan: nope, sorry, don't know where too look for that. Maybe it has something to do with the fact that the code is not to be found on that http://code.google.com/p/swfobject/  url in swfobject.min.js? That's redirecting to https://github.com/swfobject/swfobject nowadays.
I tried changing that to the github url, but that did not have any effect.

Any clue on why it suddenly conflicts with that x-mas theme so it keeps scrolling when getting to the bottom?
Greetings, Black Tiger

digger

Updated version 1.3 https://github.com/realdigger/SMF-Yandex-Garland


  • Some code improvements.
  • Flash and jQuery dependency removed.
  • Add option to enable/disable garland on mobile devices.

@rjen

Quote from: digger on December 27, 2017, 03:47:40 PM
Updated version 1.3 https://github.com/realdigger/SMF-Yandex-Garland


  • Some code improvements.
  • Flash and jQuery dependency removed.
  • Add option to enable/disable garland on mobile devices.

Thanks!

just updated (3rd day of Christmas, still possible I guess) and it works again!
Running SMF 2.1 with latest TinyPortal at www.fjr-club.nl

Advertisement: