Advertisement:

Author Topic: Help with Tab order on Registration Page when you add Custom Profile Fields  (Read 3133 times)

Offline rgecy

  • Jr. Member
  • **
  • Posts: 197
    • SideImagingSoft.com
I have added several custom profile fields in 2.0 to my registration page and the Location mod installed.  The fields are not required, but when a user tabs through them, it skips from the Location field directly to the bottom "I agree" check box.

Since it skips them, the user just doesn't worry about it and the info is not entered.

Any help or suggestions on how to solve this?

Thanks,

Robert

Offline sshahnawaz

  • Sr. Member
  • ****
  • Posts: 714
  • Gender: Male
  • Let's ask questions to oursleves... Who we are?
    • www.facebook.com/sshahnwaz on Facebook
    • @metheuser on Twitter
    • Global Community and Directory Zone
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #1 on: September 20, 2009, 05:14:21 AM »
There must be some mod installed to redirect the users to bottom. Would you like to provide the list of mods installed here?
How to Make Money Online - Urdu Description https://www.youtube.com/watch?v=0Deggh2ZxNE

Offline rgecy

  • Jr. Member
  • **
  • Posts: 197
    • SideImagingSoft.com
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #2 on: September 20, 2009, 11:02:17 PM »
Removed the Location Profile field from the registration page and still have the problem. It completely skips the custom profile fields.


Modification Packages
 Mod Name Version
 
1. Ultimate Profile 0.9     
2. SMF Media Gallery 2.0 beta 4     
3. YouTube BBCode 2.4     
4. SMG Slideshow Addon 1.0  [ Apply Mod ] [ List Files ] [ Delete ] 
5. PaypalDonations 2.0     
6. Google Member Map 1.0 beta 4     
7. Admin member list registration date 1.0  [ Apply Mod ] [ List Files ] [ Delete ] 
8. Pm Number in All Pages 1.0     
9. Order Stickied Topics 1.01     
10. Custom Copyright 1.1     
11. Custom Form Mod 1.5     
12. Enhanced Dropdown 1.1     
13. Attachment Icon File 1.0     
14. Admin color in topic view 0.1  [ Apply Mod ] [ List Files ] [ Delete ]  
15. Simple staff color legend 1.1     
16. Downloads System 1.2.6     
17. [user] BBC Tag 1.0.1     
18. Lots_o_Smileys 1.0     
19. MessagePreviewOnHover 1.7     
20. Display Location on posts 1.0     
21. Meta-Tags 1.0.2     
22. PDF Tag 1.1     
23. PM to New Members 1.2     
24. Save PM as HTML 1.0.7     
25. Message for your guests 0.1     
26. SMF Links 2.0.1     
27. Bot Buster 1.1     
28. Images On Board 2.1     
29. Header Rotator 2.1  [ Apply Mod ] [ List Files ] [ Delete ] 
30. Ad Managment 2.3.5     
31. Internal_Links_Use_Same_Window 1.2     
32. New Style Message Icon 1.1     
33. Attachments In Message 1.3.0  [ Apply Mod ] [ List Files ] [ Delete ]  
34. Clickable Avatars 1.1.0     
35. Reply Button in All Posts 1.1     
36. AjaxChat Integration 3.2.1
37. Aeva ~ Auto-Embed Video & Audio 6.9.100     
38. SimplePortal 2.3     
 
« Last Edit: September 20, 2009, 11:11:25 PM by rgecy »

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #3 on: September 21, 2009, 03:48:02 AM »
Please can I have a link to the site so I can see?
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline rgecy

  • Jr. Member
  • **
  • Posts: 197
    • SideImagingSoft.com
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #4 on: September 21, 2009, 04:40:34 AM »
h**p://forums.sideimagingsoft.com

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #5 on: September 21, 2009, 05:11:24 AM »
Can you please attach your theme's Register.template.php file?
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline doughboy99

  • Semi-Newbie
  • *
  • Posts: 98
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #6 on: September 21, 2009, 05:21:38 AM »
This is happening for me as well the only mods in common are Simpleportal and Downloads system.

    Mod Name     Version     
1.    SMF Gallery Pro    2.5.3.1    [ Uninstall ] [ List Files ] [ Delete ]
2.    Sarcasmics smiley set    1.1.0.1    [ Uninstall ] [ List Files ] [ Delete ]
3.    SimplePortal    2.3    [ Uninstall ] [ List Files ] [ Delete ]
4.    Attachments In Message    1.3.0    [ Uninstall ] [ List Files ] [ Delete ]
5.    Downloads System    1.2.6    [ Uninstall ] [ List Files ] [ Delete ]
6.    SMF for iPhone    1.0    [ Uninstall ] [ List Files ] [ Delete ]
7.    Irritate lurkers with 0 posts    0.1    [ Uninstall ] [ List Files ] [ Delete

If you tab enough times you eventually get back to the section with the custom fields in.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #7 on: September 21, 2009, 05:41:05 AM »
It's nothing to do with those mods. If you'd like me to fix it please attach your theme's Register.template.php file.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline doughboy99

  • Semi-Newbie
  • *
  • Posts: 98
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #8 on: September 21, 2009, 11:46:57 AM »
Thankyou. File attached

Offline rgecy

  • Jr. Member
  • **
  • Posts: 197
    • SideImagingSoft.com
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #9 on: September 21, 2009, 12:15:46 PM »
Thank You.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #10 on: September 21, 2009, 03:17:08 PM »
doughboy99: Please attach your theme's Register.template.php - not Sources/Register.template.php

rgecy: I'll get on that in just a moment.

EDIT: rgecy: Please can I have a link to your forum to see the order it is actually using? Your file seems fine.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline doughboy99

  • Semi-Newbie
  • *
  • Posts: 98
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #11 on: September 21, 2009, 03:26:27 PM »
Sorry. I'm using the Denge theme which doesnt have that file.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #12 on: September 21, 2009, 04:13:48 PM »
In which case it's using the default theme's file, which should be correct, meaning you're likely in the same boat as rgecy.

I need to go back through what this template does to be sure of how to fix it though :(
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline rgecy

  • Jr. Member
  • **
  • Posts: 197
    • SideImagingSoft.com
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #13 on: September 21, 2009, 06:08:13 PM »
It is posted above but I also PM'd to you.

Thanks,

Robert

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #14 on: September 21, 2009, 06:32:21 PM »
Just to follow up on this.

I've actually reported this as a bug in RC1.2, and I'm looking into fixing it in the source right now.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline doughboy99

  • Semi-Newbie
  • *
  • Posts: 98
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #15 on: September 21, 2009, 06:43:05 PM »
Excellent thankyou.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline rgecy

  • Jr. Member
  • **
  • Posts: 197
    • SideImagingSoft.com
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #17 on: September 21, 2009, 08:59:12 PM »
Is there a way we can chnage the tab indexes in the existing code?

Robert

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,982
    • StoryBB/StoryBB on GitHub
Re: Help with Tab order on Registration Page when you add Custom Profile Fields
« Reply #18 on: September 21, 2009, 09:16:12 PM »
That's the problem, in fact.

The main registration template figures it out as it goes along, and adds it up as it does. The custom profile fields are held outside, meaning you can't directly do that.

I did outline two options in the bug tracker report though both are pretty ugly. Option 1 would be simpler though.

Essentially you'd go through the instances in Register.template.php and replace:
Code: [Select]
tabindex="', $context['tabindex']++, '"with
Code: [Select]
tabindex="0"
With the exception of the first one, that is; the first one has to be a 1.

Then you have to go through and edit a certain part of Profile.php in the loadCustomProfiles function where it builds the field_html element.

It's ugly, and it's a hack but it should work.
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.