• Welcome to Simple Machines Community Forum. Please login or sign up.
December 07, 2021, 07:04:18 PM

News:

SMF 2.0.18 has been released! Please update. Read more.


SMF 2.0 RC1 bug

Started by Mr_Lon, February 11, 2009, 10:00:15 AM

Previous topic - Next topic

Mr_Lon

February 11, 2009, 10:00:15 AM Last Edit: February 14, 2009, 01:21:31 PM by regularexpression
I have a Geocaching website and just updated my forums from SMF 2.0 beta4 to SMF 2.0 RC1.  I have some members that are using "Mozilla Firefox" and with SMF 2.0 beta 4 there was NO problem but now with SMF 2.0 RC1 the posts are all messed up with Firefox?

Attached are two pictures, one labled "Firefox" and the other "Explorer" to show what is happening.
This needs to be looked at.

Dragooon

This issue is with your theme, as the templates have changed, it should be fine in the default theme (Core).

Mr_Lon

February 11, 2009, 10:48:21 AM #2 Last Edit: February 11, 2009, 11:08:25 AM by Mr_Lon
Quote from: Dragooon on February 11, 2009, 10:23:21 AM
This issue is with your theme, as the templates have changed, it should be fine in the default theme (Core).

NO This is the "default" theme, I have only changed the background colors in the "default theme Style sheet".

Dragooon

Are you sure you updated the CSS files with the latest ones?

Mr_Lon

I just re-uploaded the new RC1 default theme CSS files and it made no difference?

I didn't have this problem with beta 4,  that is what puzzles me....
Should I try the old beta 4 CSS files?

Lon

anduriell

February 11, 2009, 05:30:37 PM #5 Last Edit: February 11, 2009, 05:56:19 PM by anduriell
Same Here.. It's a RC1 bug. I have clean installation.

And the funny thing is that only happens in firefox (3.0.6 so far..)
Is there anyway to fix this?

Mr_Lon

I just tryed the old beta 4 default theme CSS files and that didn't work either, so I reinstalled the RC1 CSS files.

Lon

metallica48423

I am using 2.0 RC1 but have no problems with the posts that I am aware of... Though my theme does have a custom Display Template.

What browsers are being used?
Justin O'Leary
Ex-Project Manager
Ex-Lead Support Specialist

QuoteMicrosoft wants us to "Imagine life without walls"...
I say, "If there are no walls, who needs Windows?"


Useful Links:
Online Manual!
How to Help us Help you   
Search
Settings Repair Tool
     

Mr_Lon

Please read the first post

"I have a Geocaching website and just updated my forums from SMF 2.0 beta4 to SMF 2.0 RC1.  I have some members that are using "Mozilla Firefox" and with SMF 2.0 beta 4 there was NO problem but now with SMF 2.0 RC1 the posts are all messed up with Firefox?"\

My Windows Internet Explorer is just fine, it's Firefox.


Brettflan

Can you link to the post in question, or is it a private forum? Being able to look at it directly and view the page source would be helpful.

Mr_Lon

The site is http://www.greathides.com/
Just remember in Explorer it is fine! Using Firefox is the problem.

Also it is the SMF default theme I just changes some colors and graphics to give me the brown look.
Lon

ThorstenE

Quote from: Mr_Lon on February 11, 2009, 01:15:11 PM
I just re-uploaded the new RC1 default theme CSS files and it made no difference?
when re-uploading the CSS-Files you should clean the SMF cache and also your browser cache. can you attach your CSS-Files please?

Brettflan

February 12, 2009, 04:29:30 PM #12 Last Edit: February 12, 2009, 04:31:01 PM by Brettflan
Your theme's style.css file has this for the signature:
/* All the signatures used in the forum.  If your forum users use Mozilla, Opera, or Safari, you might add max-height here ;). */
.signature
{
width: 100%;
overflow: auto;
padding-bottom: 3px;
line-height: 1.3em;
}


The normal RC1 default theme's style.css has this:
/* All the signatures used in the forum.  If your forum users use Mozilla, Opera, or Safari, you might add max-height here ;). */
.signature
{
clear: right;
padding: 1em 0 3px 0;
border-top: solid 1px #888;
width: 100%;
overflow: auto;
line-height: 1.3em;
}

Yours is missing the code to clear down to a new line if there's anything on the right of it, as well as the top padding (the 1em specified).
It's also missing the border, but that's a matter of personal taste.

Mr_Lon

February 12, 2009, 04:45:48 PM #13 Last Edit: February 12, 2009, 04:49:06 PM by Mr_Lon
Quote from: Brettflan on February 12, 2009, 04:29:30 PM
Your theme's style.css file has this for the signature:
/* All the signatures used in the forum.  If your forum users use Mozilla, Opera, or Safari, you might add max-height here ;). */
.signature
{
width: 100%;
overflow: auto;
padding-bottom: 3px;
line-height: 1.3em;
}


The normal RC1 default theme's style.css has this:
/* All the signatures used in the forum.  If your forum users use Mozilla, Opera, or Safari, you might add max-height here ;). */
.signature
{
clear: right;
padding: 1em 0 3px 0;
border-top: solid 1px #888;
width: 100%;
overflow: auto;
line-height: 1.3em;
}

Yours is missing the code to clear down to a new line if there's anything on the right of it, as well as the top padding (the 1em specified).
It's also missing the border, but that's a matter of personal taste.

Thank you very much! I made the Style.css change and that did the trick for Most if it, but it still is not quite right.
One question: Were is this in the RC1 upgrade? I don.t see it?


Lon

Brettflan

February 12, 2009, 04:49:27 PM #14 Last Edit: February 12, 2009, 04:52:13 PM by Brettflan
I've only used the large upgrade package myself, where it's included as part of the default theme.

EDIT: by the way, you'll need to tell your users to do a full refresh or clear their browser cache in order to make sure their browsers reload the changed CSS file.

Mr_Lon


habakuk

Might want to check the display.template.php and replace:

      <div class="post" id="msg_', $message['id'], '"', '>';

with

      <div class="post floatleft" id="msg_', $message['id'], '"', '>';

This solved the problem for me.




Mr_Lon

Quote from: habakuk on February 13, 2009, 03:01:38 PM
Might want to check the display.template.php and replace:

      <div class="post" id="msg_', $message['id'], '"', '>';

with

      <div class="post floatleft" id="msg_', $message['id'], '"', '>';

This solved the problem for me.




This is it! I made the change described above and everyone on my forums that are using "Firefox" have come back and are happy!
I have installed Firefox for testing and my forums now do look close to the same between Firefox and Explorer!

Thanks - Problem solved


This small change should be added to SMF RC1 for a final fix.

:D

Advertisement: