Attachments In Message

[drhamza]

yeah, and please try to make it wysiwyg compatible, thanks a lot for the great mod... this one should be an essential feature in smf

[Bruno36]

Hello!

An update is planned for SMF 2.0 RC2

[drhamza]

it's already updated

[alado]

I look forward to RC2

[russ skinner]

Bruno36,

That's great to hear.  Without doubt the most utilised mod on the forum I look after.

Any idea on timing?

Russ

[drhamza]

fixing the wysiwyg error would be awesome, and updating it to RC2
great mod, should be added to the standard smf features in my opinion

[purper]

I really would like this to be changed for RC2, but the autor is last seen june 25, 2009!
Someone else might wanna give this a try?

[C4G-TK]

great mod, should be added to the standard smf features in my opinion

I really would like this to be changed for RC2, but the autor is last seen june 25, 2009!

Agreed x2

[chadon]

What makes SMF so great is all the mods available. What makes it so bad is when the mods' authors stop supporting them.

I also agree, if there is one mod that should be a standard feature, it's this one.

[MATTEK]

it's already updated

The link to mod does not say compatible with rc2 2.0

[C4G-TK]

I'll try it.  Give me a second.

UPDATE
I get all edits in Display.template and Post.template showing errors when using 1.3.0 which is the most recent package.  Anyone else try?



Display.template code is changed to this:

Code Select Expand

// Assuming there are attachments...
if (!empty($message['attachment']))
{
echo '
<div id="msg_', $message['id'], '_footer" class="attachments smalltext">
<div style="overflow: ', $context['browser']['is_firefox'] ? 'visible' : 'auto', ';">';

$last_approved_state = 1;
foreach ($message['attachment'] as $attachment)
{
// Show a special box for unapproved attachments...
if ($attachment['is_approved'] != $last_approved_state)
{
$last_approved_state = 0;
echo '
<fieldset>
<legend>', $txt['attach_awaiting_approve'], '&nbsp;[<a href="', $scripturl, '?action=attachapprove;sa=all;mid=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve_all'], '</a>]</legend>';
}

if ($attachment['is_image'])
{
if ($attachment['thumbnail']['has_thumb'])
echo '
<a href="', $attachment['href'], ';image" id="link_', $attachment['id'], '" onclick="', $attachment['thumbnail']['javascript'], '"><img src="', $attachment['thumbnail']['href'], '" alt="" id="thumb_', $attachment['id'], '" border="0" /></a><br />';
else
echo '
<img src="' . $attachment['href'] . ';image" alt="" width="' . $attachment['width'] . '" height="' . $attachment['height'] . '" border="0" /><br />';
}
echo '
<a href="' . $attachment['href'] . '"><img src="' . $settings['images_url'] . '/icons/clip.gif" align="middle" alt="*" border="0" />&nbsp;' . $attachment['name'] . '</a> ';

if (!$attachment['is_approved'])
echo '
[<a href="', $scripturl, '?action=attachapprove;sa=approve;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve'], '</a>]&nbsp;|&nbsp;[<a href="', $scripturl, '?action=attachapprove;sa=reject;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['delete'], '</a>] ';
echo '
(', $attachment['size'], ($attachment['is_image'] ? ', ' . $attachment['real_width'] . 'x' . $attachment['real_height'] . ' - ' . $txt['attach_viewed'] : ' - ' . $txt['attach_downloaded']) . ' ' . $attachment['downloads'] . ' ' . $txt['attach_times'] . '.)<br />';
}

// If we had unapproved attachments clean up.
if ($last_approved_state == 0)
echo '
</fieldset>';

echo '
</div>
</div>';
}



The edits code for Post.template has changed to this:

Edit 1:

Code Select Expand

foreach ($context['current_attachments'] as $attachment)
echo '
<dd class="smalltext">
<label for="attachment_', $attachment['id'], '"><input type="checkbox" id= "attachment_', $attachment['id'], '" name="attach_del[]" value="', $attachment['id'], '"', empty($attachment['unchecked']) ? ' checked="checked"' : '', ' class="input_check" /> ', $attachment['name'], (empty($attachment['approved']) ? ' (' . $txt['awaiting_approval'] . ')' : ''), '</label>
</dd>';
echo '
</dl>';

Edit 2:

Code Select Expand

<input type="file" size="60" name="attachment[]" class="input_file" />';

Edit 3:

Code Select Expand

function addAttachment()
{
allowed_attachments = allowed_attachments - 1;
if (allowed_attachments <= 0)
return alert("', $txt['more_attachments_error'], '");

setOuterHTML(document.getElementById("moreAttachments"), \'<dd class="smalltext"><input type="file" size="60" name="attachment[]" class="input_file" /><\' + \'/dd><dd class="smalltext" id="moreAttachments"><a href="#" onclick="addAttachment(); return false;">(', $txt['more_attachments'], ')<\' + \'/a><\' + \'/dd>\');

return true;
}



At least these are the TESTS that failed on my forum.

it's already updated

  So, I'm unsure how it could be updated.

[drhamza]

sorry, i thought it was already updated :$

[C4G-TK]

BTW, the edits I posted are what is IN RC2 and NOT the edits needed to be made in order for this to work in RC2. 

I'll try it.  Give me a second.

UPDATE
I get all edits in Display.template and Post.template showing errors when using 1.3.0 which is the most recent package.  Anyone else try?



Display.template code is changed to this:

Code Select Expand

// Assuming there are attachments...
if (!empty($message['attachment']))
{
echo '
<div id="msg_', $message['id'], '_footer" class="attachments smalltext">
<div style="overflow: ', $context['browser']['is_firefox'] ? 'visible' : 'auto', ';">';

$last_approved_state = 1;
foreach ($message['attachment'] as $attachment)
{
// Show a special box for unapproved attachments...
if ($attachment['is_approved'] != $last_approved_state)
{
$last_approved_state = 0;
echo '
<fieldset>
<legend>', $txt['attach_awaiting_approve'], '&nbsp;[<a href="', $scripturl, '?action=attachapprove;sa=all;mid=', $message['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve_all'], '</a>]</legend>';
}

if ($attachment['is_image'])
{
if ($attachment['thumbnail']['has_thumb'])
echo '
<a href="', $attachment['href'], ';image" id="link_', $attachment['id'], '" onclick="', $attachment['thumbnail']['javascript'], '"><img src="', $attachment['thumbnail']['href'], '" alt="" id="thumb_', $attachment['id'], '" border="0" /></a><br />';
else
echo '
<img src="' . $attachment['href'] . ';image" alt="" width="' . $attachment['width'] . '" height="' . $attachment['height'] . '" border="0" /><br />';
}
echo '
<a href="' . $attachment['href'] . '"><img src="' . $settings['images_url'] . '/icons/clip.gif" align="middle" alt="*" border="0" />&nbsp;' . $attachment['name'] . '</a> ';

if (!$attachment['is_approved'])
echo '
[<a href="', $scripturl, '?action=attachapprove;sa=approve;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['approve'], '</a>]&nbsp;|&nbsp;[<a href="', $scripturl, '?action=attachapprove;sa=reject;aid=', $attachment['id'], ';', $context['session_var'], '=', $context['session_id'], '">', $txt['delete'], '</a>] ';
echo '
(', $attachment['size'], ($attachment['is_image'] ? ', ' . $attachment['real_width'] . 'x' . $attachment['real_height'] . ' - ' . $txt['attach_viewed'] : ' - ' . $txt['attach_downloaded']) . ' ' . $attachment['downloads'] . ' ' . $txt['attach_times'] . '.)<br />';
}

// If we had unapproved attachments clean up.
if ($last_approved_state == 0)
echo '
</fieldset>';

echo '
</div>
</div>';
}



The edits code for Post.template has changed to this:

Edit 1:

Code Select Expand

foreach ($context['current_attachments'] as $attachment)
echo '
<dd class="smalltext">
<label for="attachment_', $attachment['id'], '"><input type="checkbox" id= "attachment_', $attachment['id'], '" name="attach_del[]" value="', $attachment['id'], '"', empty($attachment['unchecked']) ? ' checked="checked"' : '', ' class="input_check" /> ', $attachment['name'], (empty($attachment['approved']) ? ' (' . $txt['awaiting_approval'] . ')' : ''), '</label>
</dd>';
echo '
</dl>';

Edit 2:

Code Select Expand

<input type="file" size="60" name="attachment[]" class="input_file" />';

Edit 3:

Code Select Expand

function addAttachment()
{
allowed_attachments = allowed_attachments - 1;
if (allowed_attachments <= 0)
return alert("', $txt['more_attachments_error'], '");

setOuterHTML(document.getElementById("moreAttachments"), \'<dd class="smalltext"><input type="file" size="60" name="attachment[]" class="input_file" /><\' + \'/dd><dd class="smalltext" id="moreAttachments"><a href="#" onclick="addAttachment(); return false;">(', $txt['more_attachments'], ')<\' + \'/a><\' + \'/dd>\');

return true;
}



At least these are the TESTS that failed on my forum.

it's already updated

  So, I'm unsure how it could be updated.

[purper]

What makes SMF so great is all the mods available. What makes it so bad is when the mods' authors stop supporting them.

I also agree, if there is one mod that should be a standard feature, it's this one.

well, the great thing about mods being available is that everyone can edit and modify them. So maybe someone is able to convert it to RC2? Unfortunately I have no knowledge about php etc. so I rely on smarter members of Simple Machines forum?

[C4G-TK]

Did anybody update this yet and care to share what they did to make it work on RC2?

[ChaosEnergy]

i am stuck in one line...i m no coder, so i copied/pasted...but the post.template area is to much for my no knowledge
hope somebody will find...

i can surely send my current edits
i know which line is wrong..but all others are ok...

[Spoogs]

This may help for an RC2 version http://custom.simplemachines.org/mods/index.php?mod=2285
I dont use the mod so not sure how similar it may or may not be

[kai920]

Did anybody update this yet and care to share what they did to make it work on RC2?

I'll be trying to make this work for RC2, stay tuned. Any testers willing to test it out once I 'fix' up the package?

[C4G-TK]

Did anybody update this yet and care to share what they did to make it work on RC2?

I'll be trying to make this work for RC2, stay tuned. Any testers willing to test it out once I 'fix' up the package?

sure, I'm home sick with a cold this week, so I'll be around off and on.

[kai920]

Here's a first attempt, using the attached install.xml it should install on a fresh RC2 install properly.

One problem I've noticed so far, maybe you can help debug... when I click "more attachments" the second time I start seeing multiple (more attachments) links. I've attached a screenshot.

Let me know what other problems you find.

edit Updated with new install.xml that takes care of above issue.

PS. I've created a RC2 compatible package, but am I allowed to re-distribute it?