Advertisement:

Author Topic: Maximun edit time  (Read 18676 times)

Offline dschwab9

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 5,320
  • Gender: Male
    • Technology, Ministry and Other Ramblings
Maximun edit time
« on: September 13, 2003, 06:41:52 AM »
Has a maximum edit time for posts been considered or implemented?

I coded a 24 hour limit into my YaBB SE, bit it would be nice to see as a standard feature.

Keeps people from going back and changing a 6 month old posts or getting mad and deleting all their posts.

Offline Seph|roth

  • Full Member
  • ***
  • Posts: 432
  • Gender: Male
  • Final Fantasy VII: Advent Children
    • Ultimate Weapon Fantasy Gaming Network
Re:Maximun edit time
« Reply #1 on: September 13, 2003, 07:42:14 AM »
Yes, i think that's a very good idea... i'd say 2 or three days max.

Offline Valconeye

  • Jr. Member
  • **
  • Posts: 183
  • Gender: Male
    • WarCraftWars
Re:Maximun edit time
« Reply #2 on: September 14, 2003, 01:59:45 AM »
well if you have an auto prune (nice feature btw) you wouldnt need this mod.

Offline David

  • Destroyer Dave
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,928
  • Gender: Male
    • David Recordon
Re:Maximun edit time
« Reply #3 on: September 14, 2003, 02:31:38 AM »
Already implemented here.
This space for rent.

Offline dschwab9

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 5,320
  • Gender: Male
    • Technology, Ministry and Other Ramblings
Re:Maximun edit time
« Reply #4 on: September 14, 2003, 03:02:39 AM »
well if you have an auto prune (nice feature btw) you wouldnt need this mod.

What does that have to do with maximun edit time?  I'm saying that after a day or two, I shouldn't be able to edit this post.  I don't this is implemented (or maybe it's just not turned on)m because I just edited a post from Aug 10 to test, and it let me.

Offline Valconeye

  • Jr. Member
  • **
  • Posts: 183
  • Gender: Male
    • WarCraftWars
Re:Maximun edit time
« Reply #5 on: September 14, 2003, 03:21:07 AM »
Quote
Keeps people from going back and changing a 6 month old posts or getting mad and deleting all their posts.

was what i was refering to

Offline [Unknown]

  • SMF Friend
  • SMF Master
  • *
  • Posts: 36,102
  • Gender: Male
Re:Maximun edit time
« Reply #6 on: September 14, 2003, 05:29:03 AM »
Already implemented here.

Not that I knew of, exactly.. although I personally don't feel this is all that useful, it could easily be added in.

-[Unknown]

Offline Brian Lacy

  • Semi-Newbie
  • *
  • Posts: 64
  • Gender: Male
  • I create. Therefore I am.
Re:Maximun edit time
« Reply #7 on: September 14, 2003, 06:46:05 PM »
I can certainly see a use for it if you have people on your forum that like to go back and delete their post or change what they posted long after the fact, so that thread continuity is destroyed. I personally have only had or seen such a problem a couple of times, and a couple of times isn't that big a deal.

Offline dschwab9

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 5,320
  • Gender: Male
    • Technology, Ministry and Other Ramblings
Re:Maximun edit time
« Reply #8 on: September 15, 2003, 04:15:20 PM »
Quote
Keeps people from going back and changing a 6 month old posts or getting mad and deleting all their posts.

was what i was refering to

Still has absolutely nothing to do with autoprune.  ???

Quote
Not that I knew of, exactly.. although I personally don't feel this is all that useful, it could easily be added in.

Depends on the type of forum you run and your userbase.  In my case, a couple of the forums are technical related, and when someone posts a question or other info, 10 people reply to it, then the original poster decides to change his message, then all the replies are invalid and the thread is effectively trashed.  I've seen it happen several times, which is why I implemented the limit.  Also had a couple of cases where a user got mad and threatened to delete al his posts.  I'm sure I'm not the only one who has had these problems.

Offline helenbpd

  • Jr. Member
  • **
  • Posts: 181
    • The Nook at BPDCentral
Re: Maximum edit time
« Reply #9 on: November 02, 2004, 12:36:16 PM »
My forum desperately needs an editing time-limit as well.  We have a number of contentious folks who like to go back and erase/edit their posts after others have responded, confusing the thread and enabling a lot of historical revisionism of debates etc.  (Plus, in these cases it's just plain rude to other members.)

We'd like to be able to set a, say, 60-minute time limit on any editing of a new post by its author.  After that time elapses, no more editing or deletion of the post would be possible.  [However, we do want to retain eternal editing rights for moderators/admins.]

As it stands, we can:

1. disallow all general members from editing, ever
2. allow all general members to edit at will

[The "courtesy edit time" simply refers to when a "modified by" note will show up at the bottom, right?  (After 5,10,15 min, etc.)]

Rather than grant certain groups (say, members w/50 posts) full editing rights, we very much want to set a standard time-limit for all members for every post.  As the software stands, I can't figure out how to do it.

Do consider!  Desperately needed!  :)

Helen
« Last Edit: November 02, 2004, 12:37:57 PM by helenbpd »

Offline codenaught

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 14,653
  • Gender: Male
  • Formerly Known As akabugeyes
Re: Maximun edit time
« Reply #10 on: November 02, 2004, 04:10:19 PM »
Personally I think it would be nice to not completely remove the ability to edit a message in X time but have any edited messages after X days require approval by one with the powers to do so. So when a moderator for example sees a post he could see the original post and under it there can be a link saying, 'This user has requested to edit this post, view comparison of revision to original post' and so the moderator could be able to determine whether to allow the edit or not. This may not work as well with really really old posts unless there was a modified lookup section in the admin cp or something where you can view all of the edit requests.
Dev Consultant
Former SMF Doc Coordinator

Offline [Unknown]

  • SMF Friend
  • SMF Master
  • *
  • Posts: 36,102
  • Gender: Male
Re: Maximun edit time
« Reply #11 on: November 03, 2004, 09:58:18 PM »
Find, Sources/Post.php:
Code: [Select]
// Make sure the user isn't spamming the board.
if (!isset($_REQUEST['msg']))
spamProtection('spam');

Add after:
Code: [Select]
if (!empty($modSettings['edit_wait_time']) && $row['posterTime'] + $modSettings['edit_wait_time'] * 60 < time() && !allowedTo('moderate_board'))
fatal_error('You\'re not allowed to edit your posts anymore!', false);

Find, Sources/Display.php:
Code: [Select]
'can_modify' => allowedTo('modify_any') || (allowedTo('modify_replies') && $context['user']['started']) || (allowedTo('modify_own') && $message['ID_MEMBER'] == $ID_MEMBER),
'can_remove' => allowedTo('remove_any') || (allowedTo('remove_replies') && $context['user']['started']) || (allowedTo('remove_own') && $message['ID_MEMBER'] == $ID_MEMBER),

Replace:
Code: [Select]
'can_modify' => allowedTo('modify_any') || (allowedTo('modify_replies') && $context['user']['started']) || (allowedTo('modify_own') && $message['ID_MEMBER'] == $ID_MEMBER && (empty($modSettings['edit_disable_time']) || $message['posterTime'] + $modSettings['edit_wait_time'] * 60 > time())),
'can_remove' => allowedTo('remove_any') || (allowedTo('remove_replies') && $context['user']['started']) || (allowedTo('remove_own') && $message['ID_MEMBER'] == $ID_MEMBER),

That will change the meaning of the setting for you.

-[Unknown]

williammc

  • Guest
Re: Maximun edit time
« Reply #12 on: November 05, 2004, 02:46:04 AM »
Curious if there is a way to have edit button disppear after a certain amount of time(12 hours or more).

And whats above in the code is that seconds/minutes/hours/days.  :D

Offline Kender

  • Jr. Member
  • **
  • Posts: 294
  • Gender: Male
  • I am Kender
Re: Maximun edit time
« Reply #13 on: November 05, 2004, 02:54:55 AM »
why not create a usergroup for people who abuse edit
have permissions for that usergroup restricted to no edit no delete
when someone does something you dont like, throw them in that usergroup
http://chucknorris2012.com  Avoid a roundhouse kick to the head!  Sign the petition

williammc

  • Guest
Re: Maximun edit time
« Reply #14 on: November 05, 2004, 02:57:56 AM »
why not create a usergroup for people who abuse edit
have permissions for that usergroup restricted to no edit no delete
when someone does something you dont like, throw them in that usergroup
That would make things easier, who wants the easy way out. ;)

Offline Kender

  • Jr. Member
  • **
  • Posts: 294
  • Gender: Male
  • I am Kender
Re: Maximun edit time
« Reply #15 on: November 05, 2004, 03:02:18 AM »
silly me
http://chucknorris2012.com  Avoid a roundhouse kick to the head!  Sign the petition

Offline dschwab9

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 5,320
  • Gender: Male
    • Technology, Ministry and Other Ramblings
Re: Maximun edit time
« Reply #16 on: November 05, 2004, 07:35:27 PM »
What about people that are good for a year, then turn bad and delete all their posts?

Offline Kender

  • Jr. Member
  • **
  • Posts: 294
  • Gender: Male
  • I am Kender
Re: Maximun edit time
« Reply #17 on: November 05, 2004, 10:45:45 PM »
more that i think about it, the more i think that it would be a good idea

maybe allow edit of post for 48 hours, and only admin can delete or edit after that
that should allow people to think about what they are saying and clarify any points

though with a board where you have developing software, you can now edit post 1, to change the location of a download file

so maybe make it so that you can have it set by default with a max edit time, but be able to turn it off for a specific board
http://chucknorris2012.com  Avoid a roundhouse kick to the head!  Sign the petition

Offline helenbpd

  • Jr. Member
  • **
  • Posts: 181
    • The Nook at BPDCentral
Re: Maximun edit time
« Reply #18 on: November 06, 2004, 02:11:46 PM »
why not create a usergroup for people who abuse edit
have permissions for that usergroup restricted to no edit no delete
when someone does something you dont like, throw them in that usergroup

The problem with that is that they'd get a public user-group title in their profile, no?  (like "global moderator" etc)  Seems kind of embarassing to advertise someone's restricted status (say, "restricted buffoon") to the other members.

H

Offline helenbpd

  • Jr. Member
  • **
  • Posts: 181
    • The Nook at BPDCentral
Re: Maximun edit time
« Reply #19 on: November 06, 2004, 02:12:50 PM »
PS: oh yeah, can someone confirm where the actual time setting is in that code?

tanks!  :)