News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

[2.0b3p] Invalid RSS/ATOM/RDF feeds with "Search engine friendly URLs"

Started by TheCoolGamer, March 19, 2008, 06:58:48 AM

Previous topic - Next topic

TheCoolGamer

When "Search engine friendly URLs" is enabled, all posts in the feeds point to: index.php/$1.html$2.

SleePy

Ahh, Finally I was able to replicate this..
For Team reference this is 1790
Jeremy D ~ Site Team / SMF Developer ~ GitHub Profile ~ Join us on IRC @ Libera.chat/#smf ~ Support the SMF Support team!

Croco

OK

News.php still isn't updated with the fixed version.
you can check the last updated date of this file is 16-3-2008
while the fix was 2008-04-05

is it possible to provide this file or just the fixed function

function fix_possible_url($val)



QuoteXML feeds (RSS etc) were not having the URLs prepared right if queryless URLs were enabled. (News.php)   Revision 7042   
I am back. I will try to catch up with some stuff soon.
Regards,
Croco

My sites
Andareena.com
Andareen.net(Under Constraction :P)

New plans coming soon


Good links for you to visit:
Docs
Search

Oldiesmann

Quote from: Croco on September 06, 2008, 02:59:38 PM
OK

News.php still isn't updated with the fixed version.
you can check the last updated date of this file is 16-3-2008
while the fix was 2008-04-05

is it possible to provide this file or just the fixed function

function fix_possible_url($val)



QuoteXML feeds (RSS etc) were not having the URLs prepared right if queryless URLs were enabled. (News.php)   Revision 7042  

It's likely only fixed in 2.0. Let me go look up that revision to see what changes were made, and I'll post the info here shortly.
Michael Eshom
Christian Metal Fans

Oldiesmann

Here you go :)

Sources/News.php

Find
Code (Line 330) Select
$val = preg_replace('/^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+)(#[^"]*)?$/e', "'' . \$scripturl . '/' . strtr('\$1', '&;=', '//,') . '.html\$2'", $val);

Replace
$val = preg_replace('/^' . preg_quote($scripturl, '/') . '\?((?:board|topic)=[^#"]+)(#[^"]*)?$/e', '\'\' . $scripturl . \'/\' . strtr(\'$1\', \'&;=\', \'//,\') . \'.html$2\'', $val);
Michael Eshom
Christian Metal Fans

Advertisement: