TinyPortal

DeadMan... · February 25, 2023, 12:52:47 PM

SMF 2.1.3
TinyPortal 2.3.0
fixDbPackages advance fix for SMF2.1.3 1.0

2 Errors:

Themes/default/TPsubs.template.php (Line 436)
Type of error: Undefined
8: Undefined index: useavatar

Sources/TPortal.php (Line 1891)
Type of error: Undefined
8: Undefined index: var1

Narrowed down the issue to the default Online block.
Tried the other online block available, and no longer get the errors.

@rjen · February 25, 2023, 12:56:46 PM

No way to analyze without the full error, including the action that the user is performing.

Please provide that info.

Also is it a new install or did you upgrade.

If you upgraded: what custom blocks do you have?

DeadMan... · February 25, 2023, 01:01:46 PM

It was any page load that produced the error.
That's how narrowed it down to the one block.

This was on full install on TP, and no custom blocks at the time.

@rjen · February 25, 2023, 01:05:49 PM

Please post the action that is in the log. This error is not common on all installs, so there is something specific to yours

What block?

DeadMan... · February 25, 2023, 01:10:54 PM

Quote from: DeadMan... on February 25, 2023, 12:52:47 PMNarrowed down the issue to the default Online block.
Tried the other online block available, and no longer get the errors.

Actions:

index.php?action=forum
index.php?action=admin;area=logs;sa=errorlog;desc
index.php?action=admin
index.php?action=moderate
index.php?action=tpadmin

Like I said:

Quote from: DeadMan... on February 25, 2023, 01:01:46 PMIt was any page load that produced the error.

@rjen · February 25, 2023, 01:38:50 PM

So, issue solved...

DeadMan... · February 25, 2023, 01:40:51 PM

Unless use default Online block, yes.
I will try to make a test site later, and see if can reproduce on fresh installs of all 3.

lurkalot · February 25, 2023, 02:22:26 PM

Quote from: DeadMan... on February 25, 2023, 01:40:51 PMUnless use default Online block, yes.
I will try to make a test site later, and see if can reproduce on fresh installs of all 3.

Very strange, I haven't managed to make it blurt any errors, on various upgraded versions as well a new install Of SMF 2.1.3

DeadMan... · February 25, 2023, 02:45:22 PM

Quote from: lurkalot on February 25, 2023, 02:22:26 PMVery strange, I haven't managed to make it blurt any errors, on various upgraded versions as well a new install Of SMF 2.1.3

I can tell that it does have something to do with avatars in the default Online block, and recently discovered same errors when tried the default Recent Topics block, as well.

Could have something to do with the fact that had TP 2.2.2 installed first, then uninstalled it to install 2.3.0.

Using the secondary blocks for them works fine, and IMHO, looks better, anyways.

@rjen · February 25, 2023, 03:02:17 PM

I asked if you did a clean install. So you did not: you actually upgraded from 2.2.2

DeadMan... · February 25, 2023, 03:09:03 PM

I had 2.2.2 installed, then uninstalled it.
I did not realize before that it was outdated, or I'd have installed 2.3.0 first.
When uninstalled, I figured it would be a fresh install when installed 2.3.0.
Did not realize the database info was not deleted, until afterwards.

DeadMan... · February 25, 2023, 05:51:30 PM

I seem to have found an issue that never expected.
When do HTML block, and have a textarea in the contents, it'll cut off at the closing of the textarea.
When it does that, it goes and actually closes the textarea of the block.

Before save:
You cannot view this attachment.

After save:
You cannot view this attachment.

Notice how it got cut off?
Look at bottom, just under the textarea for the block, the image that should have been aftter the closing textarea is showing where it should not be.

I have no idea how to do the textarea so it won't clash with the block's.

@rjen · February 26, 2023, 05:02:00 AM

Confirmed. Seems to be a bug.

Workaround: do not use texarea elements in a html block, but use a div instead...

DeadMan... · February 26, 2023, 05:15:41 AM

That may not be possible for this code.
It would get parsed and not show the code for people to get.
However, another workaround is, once saved, it does actually work, even though it shows that way in the block editor. You'd have to re-paste the code every time want to change it, but it's doable.

Just figured to let you know about the issue, so maybe can be fixed.

@rjen · February 26, 2023, 05:17:03 AM

Quote from: DeadMan... on February 26, 2023, 05:15:41 AMThat may not be possible for this code.
It would get parsed and not show the code for people to get.
However, another workaround is, once saved, it does actually work, even though it shows that way in the block editor. You'd have to re-paste the code every time want to change it, but it's doable.

Just figured to let you know about the issue, so maybe can be fixed.

If you want the code to be parsed you may better put it into a php block...

DeadMan... · February 26, 2023, 05:39:03 AM

What it is, is a way for people to copy an affiliates code.
I need it where they can see the HTML code to copy.
I tried using <code> and <pre> tags, but no-go on them working.
It still gets parsed. Need something like a bbc code block for HTML:

Code Select

<a href="https://www.deadman.cc.nf" target="_blank" <img src="https://www.deadman.cc.nf/images/DK_Mini.png" alt="DeadMan Knows - Rants, Raves & Reviews" title="DeadMan Knows - Rants, Raves & Reviews" border="0" width="88" height="31" /> </a>

Not too sure what else could try.

On another note, may have found another bug:
Posts show BBC code block fine, but if have HTML in the BBC code block, the > gets removed when viewing the post on the TP frontpage:

Post:
You cannot view this attachment.

Frontpage:
You cannot view this attachment.

@rjen · February 26, 2023, 01:01:47 PM

Could you post the full code of your post in a code block here? So I can use it for some tests?

@rjen · February 26, 2023, 01:12:39 PM

Quote from: DeadMan... on February 26, 2023, 05:15:41 AMThat may not be possible for this code.
It would get parsed and not show the code for people to get.
However, another workaround is, once saved, it does actually work, even though it shows that way in the block editor. You'd have to re-paste the code every time want to change it, but it's doable.

You may better work around this by making it a BBC block: put the code in the [code ] tags and you do not need the < textarea> at all..

Code Select

<a href="https://www.deadman.cc.nf" target="_blank"><img src="https://www.deadman.cc.nf/images/DK_Mini.png" alt="DeadMan Knows - Rants, Raves & Reviews" title="DeadMan Knows - Rants, Raves & Reviews" border="0" width="88" height="31" /></a>

DeadMan... · February 26, 2023, 01:15:08 PM

Here's the part that's got the issue in the HTML (and php) block settings code block.

Code Select

<div align="center"><table width="95%">
  <tr><td colspan="2" align="center"><strong>If you would like to affiliate with us, please use the code below, to add us to your site.<br />
You can reply to the <a href="https://www.deadman.cc.nf/index.php?topic=7.0">Affiliates Requests thread</a>, to send us your code. Images need to be 88x31px.</strong></td></tr><tr>
      <td align="right" valign="middle"><textarea name="affiliates" readonly="true" onclick="this.select()" style="width:100%; height: 31px; font-size: 10pt;"><a href="https://www.deadman.cc.nf" target="_blank"><img src="https://www.deadman.cc.nf/images/DK_Mini.png" alt="DeadMan Knows - Rants, Raves & Reviews" title="DeadMan Knows - Rants, Raves & Reviews" border="0" width="88" height="31" /></a></textarea></td><td width="100" align="right" valign="middle"><img src="https://www.deadman.cc.nf/images/DK_Mini.png" alt="DeadMan Knows - Rants, Raves & Reviews" title="DeadMan Knows - Rants, Raves & Reviews" border="0" width="88" height="31" />
</td>
    </tr>
</table></div>

Here's the one that gets the > cut off on board news frontpage:

Code Select

<a href="https://www.deadman.cc.nf" target="_blank" <img src="https://www.deadman.cc.nf/images/DK_Mini.png" alt="DeadMan Knows - Rants, Raves & Reviews" title="DeadMan Knows - Rants, Raves & Reviews" border="0" width="88" height="31" /> </a>

I've found a fix, for theme using, by placing it into the template file, in the footer.
However, it would still be nice to work it via the blocks.
With having a lot of affiliates that have the HTML codes, it would be a rather pain to remake them all for a BBC block.

@rjen · February 26, 2023, 01:31:18 PM

I would realy recommend not using table layouts: that is usually a recipe for problems these days.

Change your block to BBC and try this for bbc code...

Code Select

[center][b]Affiliates Requests[/b]
If you would like to affiliate with us, please use the code below, to add us to your site.
You can reply to the <a href="https://www.deadman.cc.nf/index.php?topic=7.0"> Affiliates Requests thread</a>, to send us your code. Images need to be 88x31px.
[/center]
[code*]<a href="https://www.deadman.cc.nf" target="_blank"><img src="https://www.deadman.cc.nf/images/DK_Mini.png" alt="DeadMan Knows - Rants, Raves & Reviews" title="DeadMan Knows - Rants, Raves & Reviews" border="0" width="88" height="31" /></a>[/code*]
[img width=88 height=31]https://www.deadman.cc.nf/images/DK_Mini.png[/img]

just change the code* to code before you use it

News:

TinyPortal